Skip to content

fix: replace curly-brace node placeholders and fix Ascend URL#505

Merged
hami-robot[bot] merged 1 commit into
Project-HAMi:masterfrom
mesutoezdil:fix/node-label-ascend-vastai-placeholders
Jul 1, 2026
Merged

fix: replace curly-brace node placeholders and fix Ascend URL#505
hami-robot[bot] merged 1 commit into
Project-HAMi:masterfrom
mesutoezdil:fix/node-label-ascend-vastai-placeholders

Conversation

@mesutoezdil

@mesutoezdil mesutoezdil commented Jun 26, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Replace {ascend-node} and {vastai-node} curly-brace placeholders with angle-bracket form (<ascend-node>, <vastai-node>) to match the convention used elsewhere in the docs.

Also fix a broken URL in enable-ascend-sharing.md that had a space in the path (Huawei Ascend/mind-cluster), correcting it to Ascend/mind-cluster to match all other references to the same resource.

Files changed:

  • docs/userguide/ascend-device/enable-ascend-sharing.md
  • docs/installation/how-to-use-volcano-ascend.md
  • docs/userguide/vastai/enable-vastai-sharing.md

Summary by CodeRabbit

  • Documentation
    • Standardized node-labeling examples to use angle-bracket placeholders in setup guides.
    • Updated the Ascend sharing guide with a clearer prerequisite link label.
    • Kept the step-by-step instructions unchanged aside from these example and link text improvements.

@mesutoezdil
fix: replace curly-brace node placeholders and fix broken Ascend URL
b7279d6 
Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@hami-robot hami-robot Bot requested review from wawa0210 and windsonsea June 26, 2026 19:19
@netlify

netlify Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for project-hami ready!

Name Link
🔨 Latest commit b7279d6
🔍 Latest deploy log https://app.netlify.com/projects/project-hami/deploys/6a3ed0bdc7a393000886c2f0
😎 Deploy Preview https://deploy-preview-505--project-hami.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4ef90c4f-1c01-458f-bd6c-76409160dff1

📥 Commits

Reviewing files that changed from the base of the PR and between a3e36d4 and b7279d6.

📒 Files selected for processing (3)
  • docs/installation/how-to-use-volcano-ascend.md
  • docs/userguide/ascend-device/enable-ascend-sharing.md
  • docs/userguide/vastai/enable-vastai-sharing.md
📝 Walkthrough

Walkthrough

Documentation examples now use angle-bracket node placeholders in Ascend and Vastai labeling commands, and one Ascend prerequisite link label is shortened.

Changes

Documentation placeholder cleanup

Layer / File(s) Summary
Node-label examples and link text
docs/installation/how-to-use-volcano-ascend.md, docs/userguide/ascend-device/enable-ascend-sharing.md, docs/userguide/vastai/enable-vastai-sharing.md		 kubectl label node examples switch to angle-bracket node placeholders, and one Ascend prerequisite link label changes to “Ascend docker runtime”.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 I hopped through docs with a happy thump,
<ascend-node> and <vastai-node> did the jump.
One link grew shorter, neat and clear,
My carrot-approved notes are done right here.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main documentation changes: placeholder cleanup and the Ascend URL fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@hami-robot hami-robot Bot added the size/XS label Jun 26, 2026
windsonsea
windsonsea reviewed Jul 1, 2026
View reviewed changes

@windsonsea windsonsea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@hami-robot hami-robot Bot added the lgtm label Jul 1, 2026
@hami-robot

hami-robot Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mesutoezdil, windsonsea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot hami-robot Bot added the approved label Jul 1, 2026
@hami-robot hami-robot Bot merged commit b70235b into Project-HAMi:master Jul 1, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wawa0210 wawa0210 Awaiting requested review from wawa0210
1 more reviewer
@windsonsea windsonsea windsonsea left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@windsonsea windsonsea

Labels

approved dco-signoff: yes lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mesutoezdil @windsonsea